media: mxl692: remove impossible condition
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thu, 25 Mar 2021 08:39:56 +0000 (09:39 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 11:05:43 +0000 (13:05 +0200)
Fix the following coverity warning:

This greater-than-or-equal-to-zero comparison of an unsigned value is
always true. "opcode >= 0".

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/mxl692.c

index 86af831..8303064 100644 (file)
@@ -377,7 +377,7 @@ static int mxl692_memread(struct mxl692_dev *dev, u32 addr,
 
 static const char *mxl692_opcode_string(u8 opcode)
 {
-       if (opcode >= 0 && opcode <= MXL_EAGLE_OPCODE_INTERNAL)
+       if (opcode <= MXL_EAGLE_OPCODE_INTERNAL)
                return MXL_EAGLE_OPCODE_STRING[opcode];
 
        return "invalid opcode";