dmaengine: use sysfs_emit() to instead of scnprintf()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 30 Jan 2023 11:11:41 +0000 (13:11 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 10 Feb 2023 06:07:45 +0000 (11:37 +0530)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230130111141.59627-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmaengine.c

index c741b64..1ebbf22 100644 (file)
@@ -172,7 +172,7 @@ static ssize_t memcpy_count_show(struct device *dev,
        if (chan) {
                for_each_possible_cpu(i)
                        count += per_cpu_ptr(chan->local, i)->memcpy_count;
-               err = sprintf(buf, "%lu\n", count);
+               err = sysfs_emit(buf, "%lu\n", count);
        } else
                err = -ENODEV;
        mutex_unlock(&dma_list_mutex);
@@ -194,7 +194,7 @@ static ssize_t bytes_transferred_show(struct device *dev,
        if (chan) {
                for_each_possible_cpu(i)
                        count += per_cpu_ptr(chan->local, i)->bytes_transferred;
-               err = sprintf(buf, "%lu\n", count);
+               err = sysfs_emit(buf, "%lu\n", count);
        } else
                err = -ENODEV;
        mutex_unlock(&dma_list_mutex);
@@ -212,7 +212,7 @@ static ssize_t in_use_show(struct device *dev, struct device_attribute *attr,
        mutex_lock(&dma_list_mutex);
        chan = dev_to_dma_chan(dev);
        if (chan)
-               err = sprintf(buf, "%d\n", chan->client_count);
+               err = sysfs_emit(buf, "%d\n", chan->client_count);
        else
                err = -ENODEV;
        mutex_unlock(&dma_list_mutex);