PCI: ibmphp: Fix use-before-set in get_max_bus_speed()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Apr 2018 10:05:49 +0000 (13:05 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 20 Apr 2018 17:49:24 +0000 (12:49 -0500)
The "rc" variable is only initialized on the error path.  The caller
doesn't check the return but, if "rc" is non-zero, then this function is
basically a no-op.

Fixes: 3749c51ac6c1 ("PCI: Make current and maximum bus speeds part of the PCI core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/ibmphp_core.c

index b81ca3f..1869b04 100644 (file)
@@ -379,7 +379,7 @@ static int get_adapter_present(struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_max_bus_speed(struct slot *slot)
 {
-       int rc;
+       int rc = 0;
        u8 mode = 0;
        enum pci_bus_speed speed;
        struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;