drm: bridge: simple-bridge: clear the EDID property on failures
authorJani Nikula <jani.nikula@intel.com>
Tue, 23 Jan 2024 19:37:15 +0000 (21:37 +0200)
committerJani Nikula <jani.nikula@intel.com>
Thu, 8 Feb 2024 15:12:21 +0000 (17:12 +0200)
If EDID read fails, clear the EDID property.

Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/3e3c9505fa6859a96ead70121791fd9c4d946b6f.1706038510.git.jani.nikula@intel.com
drivers/gpu/drm/bridge/simple-bridge.c

index e0cf772..5813a2c 100644 (file)
@@ -62,6 +62,8 @@ static int simple_bridge_get_modes(struct drm_connector *connector)
                drm_edid = NULL;
        }
 
+       drm_edid_connector_update(connector, drm_edid);
+
        if (!drm_edid) {
                /*
                 * In case we cannot retrieve the EDIDs (missing or broken DDC
@@ -73,7 +75,6 @@ static int simple_bridge_get_modes(struct drm_connector *connector)
                return ret;
        }
 
-       drm_edid_connector_update(connector, drm_edid);
        ret = drm_edid_connector_add_modes(connector);
        drm_edid_free(drm_edid);