staging: rtl8188eu: remove DRIVER_PREFIX preprocessor definition
authorPhillip Potter <phil@philpotter.co.uk>
Fri, 25 Jun 2021 00:07:54 +0000 (01:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Jun 2021 07:03:51 +0000 (09:03 +0200)
Remove DRIVER_PREFIX preprocessor definition, as well as the short
block of dumping code that uses it in core/rtw_recv.c - this code
is unneeded, as normal debugging facilities can tell us what driver
this is simply by pathname etc.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210625000756.6313-22-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_recv.c
drivers/staging/rtl8188eu/include/rtw_debug.h

index 5941db9..ff2ef36 100644 (file)
@@ -1032,30 +1032,7 @@ static int validate_recv_frame(struct adapter *adapter,
        pattrib->privacy = GetPrivacy(ptr);
        pattrib->order = GetOrder(ptr);
 
-       /* Dump rx packets */
        rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
-       if (bDumpRxPkt == 1) {/* dump all rx packets */
-               if (_drv_err_ <= GlobalDebugLevel) {
-                       pr_info(DRIVER_PREFIX "#############################\n");
-                       print_hex_dump(KERN_INFO, DRIVER_PREFIX, DUMP_PREFIX_NONE,
-                                      16, 1, ptr, 64, false);
-                       pr_info(DRIVER_PREFIX "#############################\n");
-               }
-       } else if (bDumpRxPkt == 2) {
-               if ((_drv_err_ <= GlobalDebugLevel) && (type == WIFI_MGT_TYPE)) {
-                       pr_info(DRIVER_PREFIX "#############################\n");
-                       print_hex_dump(KERN_INFO, DRIVER_PREFIX, DUMP_PREFIX_NONE,
-                                      16, 1, ptr, 64, false);
-                       pr_info(DRIVER_PREFIX "#############################\n");
-               }
-       } else if (bDumpRxPkt == 3) {
-               if ((_drv_err_ <= GlobalDebugLevel) && (type == WIFI_DATA_TYPE)) {
-                       pr_info(DRIVER_PREFIX "#############################\n");
-                       print_hex_dump(KERN_INFO, DRIVER_PREFIX, DUMP_PREFIX_NONE,
-                                      16, 1, ptr, 64, false);
-                       pr_info(DRIVER_PREFIX "#############################\n");
-               }
-       }
        switch (type) {
        case WIFI_MGT_TYPE: /* mgnt */
                retval = validate_recv_mgnt_frame(adapter, precv_frame);
index 88575c4..d6b7975 100644 (file)
@@ -54,8 +54,6 @@
 #define _module_rtl8712_recv_c_                BIT(30)
 #define _module_rtl8712_led_c_         BIT(31)
 
-#define DRIVER_PREFIX  "R8188EU: "
-
 extern u32 GlobalDebugLevel;
 
 #endif /* __RTW_DEBUG_H__ */