workqueue: remove the misnamed out_unlock label in get_unbound_pool()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 22 Jul 2014 05:04:49 +0000 (13:04 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 22 Jul 2014 16:10:39 +0000 (12:10 -0400)
After the locking was moved up to the caller of the get_unbound_pool(),
out_unlock label doesn't need to do any unlock operation and the name
became bad, so we just remove this label, and the only usage-site
"goto out_unlock" is subsituted to "return pool".

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c

index 0732d33..a71cf17 100644 (file)
@@ -3463,7 +3463,7 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs)
        hash_for_each_possible(unbound_pool_hash, pool, hash_node, hash) {
                if (wqattrs_equal(pool->attrs, attrs)) {
                        pool->refcnt++;
-                       goto out_unlock;
+                       return pool;
                }
        }
 
@@ -3501,7 +3501,7 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs)
 
        /* install */
        hash_add(unbound_pool_hash, &pool->hash_node, hash);
-out_unlock:
+
        return pool;
 fail:
        if (pool)