[media] cx23885: Don't leak firmware in cx23885_card_setup()
authorJesper Juhl <jj@chaosbits.net>
Thu, 7 Apr 2011 19:23:48 +0000 (16:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 20 May 2011 12:28:47 +0000 (09:28 -0300)
We leak the memory allocated to 'fw' (the firmware) when the variable goes
out of scope.
Fix the leak by calling release_firmware(fw) before 'fw' goes out of
scope.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx23885/cx23885-cards.c

index ea88722..2354336 100644 (file)
@@ -1399,6 +1399,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
                else
                        altera_init(&netup_config, fw);
 
+               release_firmware(fw);
                break;
        }
        }