btrfs: clean up locking name in scrub_enumerate_chunks()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 31 Oct 2019 10:55:01 +0000 (13:55 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 18 Nov 2019 16:51:47 +0000 (17:51 +0100)
The "&fs_info->dev_replace.rwsem" and "&dev_replace->rwsem" refer to
the same lock but Smatch is not clever enough to figure that out so it
leads to static checker warnings.  It's better to use it consistently
anyway.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/scrub.c

index 4a5a4e4..0649430 100644 (file)
@@ -3620,7 +3620,7 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx,
                        break;
                }
 
-               down_write(&fs_info->dev_replace.rwsem);
+               down_write(&dev_replace->rwsem);
                dev_replace->cursor_right = found_key.offset + length;
                dev_replace->cursor_left = found_key.offset;
                dev_replace->item_needs_writeback = 1;
@@ -3661,10 +3661,10 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx,
 
                scrub_pause_off(fs_info);
 
-               down_write(&fs_info->dev_replace.rwsem);
+               down_write(&dev_replace->rwsem);
                dev_replace->cursor_left = dev_replace->cursor_right;
                dev_replace->item_needs_writeback = 1;
-               up_write(&fs_info->dev_replace.rwsem);
+               up_write(&dev_replace->rwsem);
 
                if (ro_set)
                        btrfs_dec_block_group_ro(cache);