bcache: avoid NULL checking to c->root in run_cache_set()
authorColy Li <colyli@suse.de>
Mon, 20 Nov 2023 05:25:03 +0000 (13:25 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 20 Nov 2023 16:17:51 +0000 (09:17 -0700)
In run_cache_set() after c->root returned from bch_btree_node_get(), it
is checked by IS_ERR_OR_NULL(). Indeed it is unncessary to check NULL
because bch_btree_node_get() will not return NULL pointer to caller.

This patch replaces IS_ERR_OR_NULL() by IS_ERR() for the above reason.

Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20231120052503.6122-11-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c

index c7ecc70..bfe1685 100644 (file)
@@ -2018,7 +2018,7 @@ static int run_cache_set(struct cache_set *c)
                c->root = bch_btree_node_get(c, NULL, k,
                                             j->btree_level,
                                             true, NULL);
-               if (IS_ERR_OR_NULL(c->root))
+               if (IS_ERR(c->root))
                        goto err;
 
                list_del_init(&c->root->list);