ionic: fix potential irq name truncation
authorShannon Nelson <shannon.nelson@amd.com>
Wed, 29 May 2024 00:02:53 +0000 (17:02 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 31 May 2024 01:10:34 +0000 (18:10 -0700)
Address a warning about potential string truncation based on the
string buffer sizes.  We can add some hints to the string format
specifier to set limits on the resulting possible string to
squelch the complaints.

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20240529000259.25775-2-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 24870da..12fda3b 100644 (file)
@@ -242,7 +242,7 @@ static int ionic_request_irq(struct ionic_lif *lif, struct ionic_qcq *qcq)
                name = dev_name(dev);
 
        snprintf(intr->name, sizeof(intr->name),
-                "%s-%s-%s", IONIC_DRV_NAME, name, q->name);
+                "%.5s-%.16s-%.8s", IONIC_DRV_NAME, name, q->name);
 
        return devm_request_irq(dev, intr->vector, ionic_isr,
                                0, intr->name, &qcq->napi);