ALSA: opti92x: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 2 Aug 2018 20:41:21 +0000 (15:41 -0500)
committerTakashi Iwai <tiwai@suse.de>
Fri, 3 Aug 2018 10:21:00 +0000 (12:21 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1165394 ("Missing break in switch")
Addresses-Coverity-ID: 1167851 ("Missing break in switch")
Addresses-Coverity-ID: 402015 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/opti9xx/opti92x-ad1848.c

index 505cd81..ac0ab6e 100644 (file)
@@ -261,6 +261,7 @@ static unsigned char snd_opti9xx_read(struct snd_opti9xx *chip,
                        retval = inb(chip->mc_base + 9);
                        break;
                }
+               /* Fall through */
 
        case OPTi9XX_HW_82C928:
        case OPTi9XX_HW_82C929:
@@ -303,6 +304,7 @@ static void snd_opti9xx_write(struct snd_opti9xx *chip, unsigned char reg,
                        outb(value, chip->mc_base + 9);
                        break;
                }
+               /* Fall through */
 
        case OPTi9XX_HW_82C928:
        case OPTi9XX_HW_82C929:
@@ -350,6 +352,7 @@ static int snd_opti9xx_configure(struct snd_opti9xx *chip,
                snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(4), 0xf0, 0xfc);
                /* enable wave audio */
                snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(6), 0x02, 0x02);
+               /* Fall through */
 
        case OPTi9XX_HW_82C925:
                /* enable WSS mode */