pd: add error handling support for add_disk()
authorLuis Chamberlain <mcgrof@kernel.org>
Mon, 27 Sep 2021 22:01:10 +0000 (15:01 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 18 Oct 2021 20:41:36 +0000 (14:41 -0600)
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/paride/pd.c

index 500b89a..e59759b 100644 (file)
@@ -938,8 +938,12 @@ static int pd_probe_drive(struct pd_unit *disk, int autoprobe, int port,
        if (ret)
                goto put_disk;
        set_capacity(disk->gd, disk->capacity);
-       add_disk(disk->gd);
+       ret = add_disk(disk->gd);
+       if (ret)
+               goto cleanup_disk;
        return 0;
+cleanup_disk:
+       blk_cleanup_disk(disk->gd);
 put_disk:
        put_disk(p);
        disk->gd = NULL;