r8169: reconfigure rx unconditionally before chip reset when resuming
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 16 Oct 2025 19:25:28 +0000 (21:25 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Oct 2025 23:57:19 +0000 (16:57 -0700)
There's a good chance that more chip versions suffer from the same
hw issue. So let's reconfigure rx unconditionally before the chip reset
when resuming. This shouldn't have any side effect on unaffected chip
versions.

Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/a5c2e2d2-226f-4896-b8f6-45e2d91f0e24@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index d18734f..2a4d9b5 100644 (file)
@@ -4995,9 +4995,7 @@ static int rtl8169_resume(struct device *device)
                clk_prepare_enable(tp->clk);
 
        /* Some chip versions may truncate packets without this initialization */
-       if (tp->mac_version == RTL_GIGA_MAC_VER_37 ||
-           tp->mac_version == RTL_GIGA_MAC_VER_46)
-               rtl_init_rxcfg(tp);
+       rtl_init_rxcfg(tp);
 
        return rtl8169_runtime_resume(device);
 }