thermal/drivers/imx_sc: Add missing of_node_put for loop iteration

Early exits from for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/thermal/imx_sc_thermal.c:93:1-33: WARNING:
    Function "for_each_available_child_of_node" should have of_node_put() before return around line 97.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210614192230.19248-1-krzysztof.kozlowski@canonical.com

diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index b01d28e..8d76dbf 100644 (file)
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
        for_each_available_child_of_node(np, child) {
                sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
                if (!sensor) {
+                       of_node_put(child);
                        of_node_put(sensor_np);
                        return -ENOMEM;
                }
@@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
                        dev_err(&pdev->dev,
                                "failed to get valid sensor resource id: %d\n",
                                ret);
+                       of_node_put(child);
                        break;
                }
 
@@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
                if (IS_ERR(sensor->tzd)) {
                        dev_err(&pdev->dev, "failed to register thermal zone\n");
                        ret = PTR_ERR(sensor->tzd);
+                       of_node_put(child);
                        break;
                }