media: sti/c8sectpfe: set correct return code
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 20 Jan 2021 08:45:23 +0000 (09:45 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 07:33:50 +0000 (08:33 +0100)
Fixes this smatch warning:

drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:829 c8sectpfe_probe() warn: missing error code 'ret'

Set ret to -EINVAL if the reset gpio was not found.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c

index 5ceb366..a7a6ea6 100644 (file)
@@ -826,6 +826,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
                        dev_err(dev,
                                "reset gpio for tsin%d not valid (gpio=%d)\n",
                                tsin->tsin_id, tsin->rst_gpio);
+                       ret = -EINVAL;
                        goto err_node_put;
                }