f2fs: simplify __allocate_data_block
authorChristoph Hellwig <hch@lst.de>
Mon, 28 Nov 2022 09:15:18 +0000 (10:15 +0100)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 6 Jan 2023 23:13:13 +0000 (15:13 -0800)
Just use a simple if block for the conditional call to
inc_valid_block_count.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/data.c

index efd3eba..697020c 100644 (file)
@@ -1431,13 +1431,12 @@ static int __allocate_data_block(struct dnode_of_data *dn, int seg_type)
                return err;
 
        dn->data_blkaddr = f2fs_data_blkaddr(dn);
-       if (dn->data_blkaddr != NULL_ADDR)
-               goto alloc;
-
-       if (unlikely((err = inc_valid_block_count(sbi, dn->inode, &count))))
-               return err;
+       if (dn->data_blkaddr == NULL_ADDR) {
+               err = inc_valid_block_count(sbi, dn->inode, &count);
+               if (unlikely(err))
+                       return err;
+       }
 
-alloc:
        set_summary(&sum, dn->nid, dn->ofs_in_node, ni.version);
        old_blkaddr = dn->data_blkaddr;
        f2fs_allocate_data_block(sbi, NULL, old_blkaddr, &dn->data_blkaddr,