net: phy: broadcom: use genphy_c45_an_config_eee_aneg in bcm_config_lre_aneg
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 6 Nov 2024 20:24:18 +0000 (21:24 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 Nov 2024 04:31:06 +0000 (20:31 -0800)
bcm_config_lre_aneg() is the only user of genphy_config_eee_advert(),
therefore use genphy_c45_an_config_eee_aneg() instead. The resulting
functionality is equivalent, and bcm_config_lre_aneg() follows the
structure of __genphy_config_aneg().
In a follow-up step genphy_config_eee_advert() can be removed.

Note: We preserve the current behavior to ignore errors.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/6e5cd4ab-28bb-4d82-b449-fec85f3d1e8a@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/bcm-phy-lib.c

index 59c2c6a..5198d66 100644 (file)
@@ -1136,7 +1136,7 @@ int bcm_config_lre_aneg(struct phy_device *phydev, bool changed)
 {
        int err;
 
-       if (genphy_config_eee_advert(phydev))
+       if (genphy_c45_an_config_eee_aneg(phydev) > 0)
                changed = true;
 
        err = bcm_setup_lre_master_slave(phydev);