jffs2: Use str_yes_no() helper function
authorThorsten Blum <thorsten.blum@linux.dev>
Tue, 12 Nov 2024 18:31:11 +0000 (19:31 +0100)
committerRichard Weinberger <richard@nod.at>
Thu, 14 Nov 2024 19:12:35 +0000 (20:12 +0100)
Remove hard-coded strings by using the str_yes_no() helper function.

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/jffs2/nodemgmt.c

index bbab2bd..6956986 100644 (file)
@@ -15,6 +15,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/compiler.h>
 #include <linux/sched/signal.h>
+#include <linux/string_choices.h>
 #include "nodelist.h"
 #include "debug.h"
 
@@ -317,9 +318,9 @@ static int jffs2_find_nextblock(struct jffs2_sb_info *c)
                           And there's no space left. At all. */
                        pr_crit("Argh. No free space left for GC. nr_erasing_blocks is %d. nr_free_blocks is %d. (erasableempty: %s, erasingempty: %s, erasependingempty: %s)\n",
                                c->nr_erasing_blocks, c->nr_free_blocks,
-                               list_empty(&c->erasable_list) ? "yes" : "no",
-                               list_empty(&c->erasing_list) ? "yes" : "no",
-                               list_empty(&c->erase_pending_list) ? "yes" : "no");
+                               str_yes_no(list_empty(&c->erasable_list)),
+                               str_yes_no(list_empty(&c->erasing_list)),
+                               str_yes_no(list_empty(&c->erase_pending_list)));
                        return -ENOSPC;
                }
 
@@ -883,7 +884,7 @@ int jffs2_thread_should_wake(struct jffs2_sb_info *c)
 
        jffs2_dbg(1, "%s(): nr_free_blocks %d, nr_erasing_blocks %d, dirty_size 0x%x, vdirty_blocks %d: %s\n",
                  __func__, c->nr_free_blocks, c->nr_erasing_blocks,
-                 c->dirty_size, nr_very_dirty, ret ? "yes" : "no");
+                 c->dirty_size, nr_very_dirty, str_yes_no(ret));
 
        return ret;
 }