ASoC: Intel: bytcr_rt5640: Sort DMI quirk list alphabetically
authorHans de Goede <hdegoede@redhat.com>
Sun, 13 May 2018 07:24:32 +0000 (09:24 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 17 May 2018 06:47:11 +0000 (15:47 +0900)
As we add more quirks it is useful to have some sort of order in the
quirk list, sort it alphabetically.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5640.c

index b00f21e..9657216 100644 (file)
@@ -401,7 +401,19 @@ static int byt_rt5640_quirk_cb(const struct dmi_system_id *id)
        return 1;
 }
 
+/* Please keep this list alphabetically sorted */
 static const struct dmi_system_id byt_rt5640_quirk_table[] = {
+       {
+               .callback = byt_rt5640_quirk_cb,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
+               },
+               .driver_data = (void *)(BYT_RT5640_IN1_MAP |
+                                                BYT_RT5640_MCLK_EN |
+                                                BYT_RT5640_SSP0_AIF1),
+
+       },
        {
                .callback = byt_rt5640_quirk_cb,
                .matches = {
@@ -426,6 +438,14 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
                                        BYT_RT5640_SSP0_AIF2 |
                                        BYT_RT5640_MCLK_EN),
        },
+       {
+               .callback = byt_rt5640_quirk_cb,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Circuitco"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Minnowboard Max B3 PLATFORM"),
+               },
+               .driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
+       },
        {
                .callback = byt_rt5640_quirk_cb,
                .matches = {
@@ -448,14 +468,6 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
                .driver_data = (void *)(BYT_RT5640_IN1_MAP |
                                        BYT_RT5640_MCLK_EN),
        },
-       {
-               .callback = byt_rt5640_quirk_cb,
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "Circuitco"),
-                       DMI_MATCH(DMI_PRODUCT_NAME, "Minnowboard Max B3 PLATFORM"),
-               },
-               .driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
-       },
        {
                .callback = byt_rt5640_quirk_cb,
                .matches = {
@@ -466,18 +478,7 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
                                        BYT_RT5640_MCLK_EN |
                                        BYT_RT5640_SSP0_AIF1),
        },
-       {
-               .callback = byt_rt5640_quirk_cb,
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
-                       DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
-               },
-               .driver_data = (void *)(BYT_RT5640_IN1_MAP |
-                                                BYT_RT5640_MCLK_EN |
-                                                BYT_RT5640_SSP0_AIF1),
-
-       },
-       {
+       {       /* Catch-all for generic Insyde tablets, must be last */
                .callback = byt_rt5640_quirk_cb,
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),