cpufreq: sti-cpufreq: fix mem leak in sti_cpufreq_set_opp_info()
authorYangtao Li <tiny.windzz@gmail.com>
Mon, 12 Oct 2020 14:01:41 +0000 (22:01 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 7 Dec 2020 07:32:37 +0000 (13:02 +0530)
Use dev_pm_opp_put_prop_name() to avoid mem leak, which free opp_table.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Yangtao Li <frank@allwinnertech.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/sti-cpufreq.c

index 4ac6fb2..aab565e 100644 (file)
@@ -223,7 +223,8 @@ use_defaults:
        opp_table = dev_pm_opp_set_supported_hw(dev, version, VERSION_ELEMENTS);
        if (IS_ERR(opp_table)) {
                dev_err(dev, "Failed to set supported hardware\n");
-               return PTR_ERR(opp_table);
+               ret = PTR_ERR(opp_table);
+               goto err_put_prop_name;
        }
 
        dev_dbg(dev, "pcode: %d major: %d minor: %d substrate: %d\n",
@@ -232,6 +233,10 @@ use_defaults:
                version[0], version[1], version[2]);
 
        return 0;
+
+err_put_prop_name:
+       dev_pm_opp_put_prop_name(opp_table);
+       return ret;
 }
 
 static int sti_cpufreq_fetch_syscon_registers(void)