drm/amd/display: Remove redundant checks for context
authorAlex Hung <alex.hung@amd.com>
Fri, 7 Jun 2024 16:46:35 +0000 (10:46 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 19 Jun 2024 16:46:08 +0000 (12:46 -0400)
The null checks for context are redundant as it was already
dereferenced previously, as reported by Coverity; therefore
the null checks are removed.

This fixes 2 REVERSE_INULL issues reported by Coverity.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c

index 33318a1..5037474 100644 (file)
@@ -505,7 +505,7 @@ void set_p_state_switch_method(
        struct vba_vars_st *vba = &context->bw_ctx.dml.vba;
        bool enable_subvp;
 
-       if (!dc->ctx || !dc->ctx->dmub_srv || !pipe_ctx || !vba || !context)
+       if (!dc->ctx || !dc->ctx->dmub_srv || !pipe_ctx || !vba)
                return;
 
        if (vba->DRAMClockChangeSupport[vba->VoltageLevel][vba->maxMpcComb] !=
index b0de4ae..f631040 100644 (file)
@@ -573,10 +573,7 @@ static bool dml2_validate_and_build_resource(const struct dc *in_dc, struct dc_s
        bool need_recalculation = false;
        uint32_t cstate_enter_plus_exit_z8_ns;
 
-       if (!context)
-               return true;
-
-       else if (context->stream_count == 0) {
+       if (context->stream_count == 0) {
                unsigned int lowest_state_idx = 0;
 
                out_clks.p_state_supported = true;