gpiolib: Fix error return code in gpiolib_dev_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 12 Mar 2021 08:04:23 +0000 (08:04 +0000)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 12 Mar 2021 10:55:20 +0000 (11:55 +0100)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 4731210c09f5 ("gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpiolib.c

index 7ec0822..6635e4e 100644 (file)
@@ -4256,7 +4256,8 @@ static int __init gpiolib_dev_init(void)
                return ret;
        }
 
-       if (driver_register(&gpio_stub_drv) < 0) {
+       ret = driver_register(&gpio_stub_drv);
+       if (ret < 0) {
                pr_err("gpiolib: could not register GPIO stub driver\n");
                bus_unregister(&gpio_bus_type);
                return ret;