drivers: net: davicom: Fixed unused but set variable with W=1
authorAndrew Lunn <andrew@lunn.ch>
Sat, 31 Oct 2020 00:58:32 +0000 (01:58 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Nov 2020 23:52:22 +0000 (15:52 -0800)
drivers/net/ethernet/davicom//dm9000.c: In function ‘dm9000_dumpblk_8bit’:
drivers/net/ethernet/davicom//dm9000.c:235:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]

The driver needs to read packet data from the device even when the
packet is known bad. There is no need to assign the data to a variable
during this discard operation.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/davicom/dm9000.c

index 5c6c8c5..3fdc70d 100644 (file)
@@ -232,32 +232,29 @@ static void dm9000_inblk_32bit(void __iomem *reg, void *data, int count)
 static void dm9000_dumpblk_8bit(void __iomem *reg, int count)
 {
        int i;
-       int tmp;
 
        for (i = 0; i < count; i++)
-               tmp = readb(reg);
+               readb(reg);
 }
 
 static void dm9000_dumpblk_16bit(void __iomem *reg, int count)
 {
        int i;
-       int tmp;
 
        count = (count + 1) >> 1;
 
        for (i = 0; i < count; i++)
-               tmp = readw(reg);
+               readw(reg);
 }
 
 static void dm9000_dumpblk_32bit(void __iomem *reg, int count)
 {
        int i;
-       int tmp;
 
        count = (count + 3) >> 2;
 
        for (i = 0; i < count; i++)
-               tmp = readl(reg);
+               readl(reg);
 }
 
 /*