powerpc/fsl_rio: fix a missing error code
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2016 22:31:52 +0000 (15:31 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 5 Aug 2016 00:02:09 +0000 (20:02 -0400)
We should set the error code here rather than incorrectly returning 0.
Otherwise static checkers complain.

Link: http://lkml.kernel.org/r/20160804053525.GM775@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Alexandre Bounine <alexandre.bounine@idt.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/powerpc/sysdev/fsl_rio.c

index 984e816..68e7c0d 100644 (file)
@@ -491,6 +491,7 @@ int fsl_rio_setup(struct platform_device *dev)
        rmu_node = of_parse_phandle(dev->dev.of_node, "fsl,srio-rmu-handle", 0);
        if (!rmu_node) {
                dev_err(&dev->dev, "No valid fsl,srio-rmu-handle property\n");
+               rc = -ENOENT;
                goto err_rmu;
        }
        rc = of_address_to_resource(rmu_node, 0, &rmu_regs);