rtase: Fix error code in rtase_init_board()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 12 Sep 2024 08:57:06 +0000 (11:57 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Sep 2024 04:23:43 +0000 (21:23 -0700)
Return an error if dma_set_mask_and_coherent() fails.  Don't return
success.

Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/f53ed942-5ac2-424b-a1ed-9473c599905e@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/rtase/rtase_main.c

index 869183e..f8777b7 100644 (file)
@@ -2023,7 +2023,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
        if (ret < 0)
                goto err_out_disable;
 
-       if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+       ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
+       if (ret) {
                dev_err(&pdev->dev, "no usable dma addressing method\n");
                goto err_out_free_res;
        }