pwm: meson: Drop always false check from .request()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 8 Nov 2021 13:46:24 +0000 (14:46 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 1 Feb 2022 07:33:47 +0000 (08:33 +0100)
In .request() pwm_get_chip_data() returns NULL always since commit
e926b12c611c ("pwm: Clear chip_data in pwm_put()"). (And if it didn't
returning 0 would be wrong because then .request() wouldn't reenable
the clk which the other driver code depends on.)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-meson.c

index 3cf3bcf..be3c806 100644 (file)
@@ -120,16 +120,10 @@ static inline struct meson_pwm *to_meson_pwm(struct pwm_chip *chip)
 static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
 {
        struct meson_pwm *meson = to_meson_pwm(chip);
-       struct meson_pwm_channel *channel;
+       struct meson_pwm_channel *channel = &meson->channels[pwm->hwpwm];
        struct device *dev = chip->dev;
        int err;
 
-       channel = pwm_get_chip_data(pwm);
-       if (channel)
-               return 0;
-
-       channel = &meson->channels[pwm->hwpwm];
-
        if (channel->clk_parent) {
                err = clk_set_parent(channel->clk, channel->clk_parent);
                if (err < 0) {