staging: vchiq: Get rid of VCHIQ_SERVICE_OPENEND callback reason
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Wed, 27 May 2020 11:53:15 +0000 (13:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 May 2020 12:04:32 +0000 (14:04 +0200)
Nobody uses it and it's routinely discarded in vchi.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20200527115400.31391-11-nsaenzjulienne@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c

index ef31e54..ae9183d 100644 (file)
@@ -1484,15 +1484,6 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header)
                                        : VCHIQ_SRVSTATE_OPEN);
                        }
 
-                       service->remoteport = remoteport;
-                       service->client_id = ((int *)header->data)[1];
-                       if (make_service_callback(service, VCHIQ_SERVICE_OPENED,
-                               NULL, NULL) == VCHIQ_RETRY) {
-                               /* Bail out if not ready */
-                               service->remoteport = VCHIQ_PORT_FREE;
-                               goto bail_not_ready;
-                       }
-
                        /* Success - the message has been dealt with */
                        unlock_service(service);
                        return 1;
index 55f9e34..75d87b6 100644 (file)
@@ -461,10 +461,6 @@ static enum vchiq_status shim_callback(enum vchiq_reason reason,
                                  VCHI_CALLBACK_SERVICE_CLOSED, NULL);
                break;
 
-       case VCHIQ_SERVICE_OPENED:
-               /* No equivalent VCHI reason */
-               break;
-
        case VCHIQ_BULK_TRANSMIT_ABORTED:
                service->callback(service->callback_param,
                                  VCHI_CALLBACK_BULK_TRANSMIT_ABORTED,