drm: Don't print messages if drivers are disabled due nomodeset
authorJavier Martinez Canillas <javierm@redhat.com>
Fri, 12 Nov 2021 13:32:25 +0000 (14:32 +0100)
committerJavier Martinez Canillas <javierm@redhat.com>
Sat, 27 Nov 2021 12:52:16 +0000 (13:52 +0100)
The nomodeset kernel parameter handler already prints a message that the
DRM drivers will be disabled, so there's no need for drivers to do that.

Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211112133230.1595307-2-javierm@redhat.com
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
drivers/gpu/drm/radeon/radeon_drv.c

index ad95de6..e8c23e3 100644 (file)
@@ -2516,10 +2516,8 @@ static int __init amdgpu_init(void)
 {
        int r;
 
-       if (vgacon_text_force()) {
-               DRM_ERROR("VGACON disables amdgpu kernel modesetting.\n");
+       if (vgacon_text_force())
                return -EINVAL;
-       }
 
        r = amdgpu_sync_init();
        if (r)
index b74cebc..380adc6 100644 (file)
@@ -637,15 +637,11 @@ static struct pci_driver radeon_kms_pci_driver = {
 
 static int __init radeon_module_init(void)
 {
-       if (vgacon_text_force() && radeon_modeset == -1) {
-               DRM_INFO("VGACON disable radeon kernel modesetting.\n");
+       if (vgacon_text_force() && radeon_modeset == -1)
                radeon_modeset = 0;
-       }
 
-       if (radeon_modeset == 0) {
-               DRM_ERROR("No UMS support in radeon module!\n");
+       if (radeon_modeset == 0)
                return -EINVAL;
-       }
 
        DRM_INFO("radeon kernel modesetting enabled.\n");
        radeon_register_atpx_handler();