projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0de6a47
)
selftests: net: netlink-dumps: validation checks
author
Jakub Kicinski
<kuba@kernel.org>
Fri, 15 Nov 2024 00:32:48 +0000
(16:32 -0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 19 Nov 2024 02:42:44 +0000
(18:42 -0800)
The sanity checks are going to get silently cast to unsigned
and always pass. Cast the sizeof to signed size.
Reviewed-by: Simon Horman <horms@kernel.org>
Link:
https://patch.msgid.link/20241115003248.733862-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/netlink-dumps.c
patch
|
blob
|
history
diff --git
a/tools/testing/selftests/net/netlink-dumps.c
b/tools/testing/selftests/net/netlink-dumps.c
index
7ee6dcd
..
84e29b7
100644
(file)
--- a/
tools/testing/selftests/net/netlink-dumps.c
+++ b/
tools/testing/selftests/net/netlink-dumps.c
@@
-56,10
+56,10
@@
TEST(test_sanity)
ASSERT_EQ(n, sizeof(dump_policies));
n = recv(netlink_sock, buf, sizeof(buf), MSG_DONTWAIT);
- ASSERT_GE(n, sizeof(struct nlmsghdr));
+ ASSERT_GE(n,
(ssize_t)
sizeof(struct nlmsghdr));
n = recv(netlink_sock, buf, sizeof(buf), MSG_DONTWAIT);
- ASSERT_GE(n, sizeof(struct nlmsghdr));
+ ASSERT_GE(n,
(ssize_t)
sizeof(struct nlmsghdr));
close(netlink_sock);
}