tools lib traceevent: Unregister handler when kvm plugin is unloaded
authorNamhyung Kim <namhyung@kernel.org>
Thu, 16 Jan 2014 02:31:12 +0000 (11:31 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 16 Jan 2014 19:26:24 +0000 (16:26 -0300)
The kvm handlers should be unregistered when the plugin is unloaded
otherwise they'll try to access invalid memory.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1389839478-5887-7-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/plugin_kvm.c

index a0e282c..9e0e8c6 100644 (file)
@@ -434,3 +434,32 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
                                       PEVENT_FUNC_ARG_VOID);
        return 0;
 }
+
+void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
+{
+       pevent_unregister_event_handler(pevent, -1, "kvm", "kvm_exit",
+                                       kvm_exit_handler, NULL);
+
+       pevent_unregister_event_handler(pevent, -1, "kvm", "kvm_emulate_insn",
+                                       kvm_emulate_insn_handler, NULL);
+
+       pevent_unregister_event_handler(pevent, -1, "kvmmmu", "kvm_mmu_get_page",
+                                       kvm_mmu_get_page_handler, NULL);
+
+       pevent_unregister_event_handler(pevent, -1, "kvmmmu", "kvm_mmu_sync_page",
+                                       kvm_mmu_print_role, NULL);
+
+       pevent_unregister_event_handler(pevent, -1,
+                                       "kvmmmu", "kvm_mmu_unsync_page",
+                                       kvm_mmu_print_role, NULL);
+
+       pevent_unregister_event_handler(pevent, -1, "kvmmmu", "kvm_mmu_zap_page",
+                                       kvm_mmu_print_role, NULL);
+
+       pevent_unregister_event_handler(pevent, -1, "kvmmmu",
+                       "kvm_mmu_prepare_zap_page", kvm_mmu_print_role,
+                       NULL);
+
+       pevent_unregister_print_function(pevent, process_is_writable_pte,
+                                        "is_writable_pte");
+}