PCI: imx6: Disable clocks in reverse order of enable
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 14 Jul 2022 07:31:07 +0000 (15:31 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 1 Aug 2022 20:34:01 +0000 (15:34 -0500)
imx6_pcie_clk_enable() enables clocks in the order:

  pcie_phy
  pcie_bus
  pcie
  imx6_pcie_enable_ref_clk

Change imx6_pcie_clk_disable() to disable them in the reverse order.

Link: https://lore.kernel.org/r/1657783869-19194-16-git-send-email-hongxing.zhu@nxp.com
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
drivers/pci/controller/dwc/pci-imx6.c

index 7a9047f..cd15122 100644 (file)
@@ -655,10 +655,10 @@ err_pcie_bus:
 
 static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
 {
+       imx6_pcie_disable_ref_clk(imx6_pcie);
        clk_disable_unprepare(imx6_pcie->pcie);
-       clk_disable_unprepare(imx6_pcie->pcie_phy);
        clk_disable_unprepare(imx6_pcie->pcie_bus);
-       imx6_pcie_disable_ref_clk(imx6_pcie);
+       clk_disable_unprepare(imx6_pcie->pcie_phy);
 }
 
 static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie)