Input: cypress-sf - constify struct i2c_device_id
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 15 Nov 2024 16:50:37 +0000 (17:50 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 19 Nov 2024 03:35:24 +0000 (19:35 -0800)
'struct i2c_device_id' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
   6438     618       0    7056    1b90 drivers/input/keyboard/cypress-sf.o

After:
=====
   text    data     bss     dec     hex filename
   6502     554       0    7056    1b90 drivers/input/keyboard/cypress-sf.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4bc3e3b4d10223d9df850fe4ba48f1cefd197082.1731689418.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cypress-sf.c

index eb1d072..335b72e 100644 (file)
@@ -208,7 +208,7 @@ static int cypress_sf_resume(struct device *dev)
 static DEFINE_SIMPLE_DEV_PM_OPS(cypress_sf_pm_ops,
                                cypress_sf_suspend, cypress_sf_resume);
 
-static struct i2c_device_id cypress_sf_id_table[] = {
+static const struct i2c_device_id cypress_sf_id_table[] = {
        { CYPRESS_SF_DEV_NAME },
        { }
 };