drm/selftests/mm: Switch to bitmap_zalloc()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 4 Mar 2019 09:29:07 +0000 (11:29 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 20 Mar 2019 17:36:06 +0000 (17:36 +0000)
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190304092908.57382-1-andriy.shevchenko@linux.intel.com
drivers/gpu/drm/selftests/test-drm_mm.c

index fbed2c9..286a0ee 100644 (file)
@@ -1615,7 +1615,7 @@ static int igt_topdown(void *ignored)
        DRM_RND_STATE(prng, random_seed);
        const unsigned int count = 8192;
        unsigned int size;
-       unsigned long *bitmap = NULL;
+       unsigned long *bitmap;
        struct drm_mm mm;
        struct drm_mm_node *nodes, *node, *next;
        unsigned int *order, n, m, o = 0;
@@ -1631,8 +1631,7 @@ static int igt_topdown(void *ignored)
        if (!nodes)
                goto err;
 
-       bitmap = kcalloc(count / BITS_PER_LONG, sizeof(unsigned long),
-                        GFP_KERNEL);
+       bitmap = bitmap_zalloc(count, GFP_KERNEL);
        if (!bitmap)
                goto err_nodes;
 
@@ -1717,7 +1716,7 @@ out:
        drm_mm_takedown(&mm);
        kfree(order);
 err_bitmap:
-       kfree(bitmap);
+       bitmap_free(bitmap);
 err_nodes:
        vfree(nodes);
 err:
@@ -1745,8 +1744,7 @@ static int igt_bottomup(void *ignored)
        if (!nodes)
                goto err;
 
-       bitmap = kcalloc(count / BITS_PER_LONG, sizeof(unsigned long),
-                        GFP_KERNEL);
+       bitmap = bitmap_zalloc(count, GFP_KERNEL);
        if (!bitmap)
                goto err_nodes;
 
@@ -1818,7 +1816,7 @@ out:
        drm_mm_takedown(&mm);
        kfree(order);
 err_bitmap:
-       kfree(bitmap);
+       bitmap_free(bitmap);
 err_nodes:
        vfree(nodes);
 err: