arm64/spinlock: fix a -Wunused-function warning
authorQian Cai <cai@lca.pw>
Thu, 23 Jan 2020 20:20:51 +0000 (15:20 -0500)
committerWill Deacon <will@kernel.org>
Mon, 10 Feb 2020 11:29:24 +0000 (11:29 +0000)
The commit f5bfdc8e3947 ("locking/osq: Use optimized spinning loop for
arm64") introduced a warning from Clang because vcpu_is_preempted() is
compiled away,

kernel/locking/osq_lock.c:25:19: warning: unused function 'node_cpu'
[-Wunused-function]
static inline int node_cpu(struct optimistic_spin_node *node)
                  ^
1 warning generated.

Fix it by converting vcpu_is_preempted() to a static inline function.

Fixes: f5bfdc8e3947 ("locking/osq: Use optimized spinning loop for arm64")
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/spinlock.h

index 102404d..9083d69 100644 (file)
  * See:
  * https://lore.kernel.org/lkml/20200110100612.GC2827@hirez.programming.kicks-ass.net
  */
-#define vcpu_is_preempted(cpu) false
+#define vcpu_is_preempted vcpu_is_preempted
+static inline bool vcpu_is_preempted(int cpu)
+{
+       return false;
+}
 
 #endif /* __ASM_SPINLOCK_H */