s390/qeth: remove TX disable from online path
authorJulian Wiedmann <jwi@linux.ibm.com>
Fri, 25 Jan 2019 14:44:20 +0000 (15:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Jan 2019 05:23:56 +0000 (21:23 -0800)
At best this is redundant, at worst it papers over a race in the
offline / online code.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c

index 3aa11f3..0d04e5a 100644 (file)
@@ -944,8 +944,6 @@ static int __qeth_l2_set_online(struct ccwgroup_device *gdev, int recovery_mode)
        if (card->info.type != QETH_CARD_TYPE_OSN)
                qeth_l2_process_vlans(card);
 
-       netif_tx_disable(card->dev);
-
        rc = qeth_init_qdio_queues(card);
        if (rc) {
                QETH_DBF_TEXT_(SETUP, 2, "6err%d", rc);
index b8a2493..2065030 100644 (file)
@@ -2346,7 +2346,6 @@ static int __qeth_l3_set_online(struct ccwgroup_device *gdev, int recovery_mode)
                if (rc)
                        QETH_DBF_TEXT_(SETUP, 2, "5err%04x", rc);
        }
-       netif_tx_disable(card->dev);
 
        rc = qeth_init_qdio_queues(card);
        if (rc) {