scsi: mptfc: Remove unneeded cast from memory allocation
authorLi Heng <liheng40@huawei.com>
Wed, 29 Jul 2020 09:19:14 +0000 (17:19 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 Aug 2020 03:15:19 +0000 (23:15 -0400)
Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING:

./drivers/message/fusion/mptfc.c:766:17-30: WARNING: casting value returned by memory allocation function to (FCPortPage0_t *) is useless.
./drivers/message/fusion/mptfc.c:907:17-30: WARNING: casting value returned by memory allocation function to (FCPortPage1_t *) is useless.

[mkp: memset()]

Link: https://lore.kernel.org/r/1596014354-59935-1-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptfc.c

index 4314a33..f92b043 100644 (file)
@@ -763,7 +763,7 @@ mptfc_GetFcPortPage0(MPT_ADAPTER *ioc, int portnum)
 
        data_sz = hdr.PageLength * 4;
        rc = -ENOMEM;
-       ppage0_alloc = (FCPortPage0_t *) pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
+       ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
        if (ppage0_alloc) {
 
  try_again:
@@ -904,7 +904,7 @@ start_over:
                if (data_sz < sizeof(FCPortPage1_t))
                        data_sz = sizeof(FCPortPage1_t);
 
-               page1_alloc = (FCPortPage1_t *) pci_alloc_consistent(ioc->pcidev,
+               page1_alloc = pci_alloc_consistent(ioc->pcidev,
                                                data_sz,
                                                &page1_dma);
                if (!page1_alloc)
@@ -922,8 +922,6 @@ start_over:
                }
        }
 
-       memset(page1_alloc,0,data_sz);
-
        cfg.physAddr = page1_dma;
        cfg.action = MPI_CONFIG_ACTION_PAGE_READ_CURRENT;