ASoC: rt5651: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:14 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:10:03 +0000 (13:10 +0000)
cppcheck warning:

sound/soc/codecs/rt5659.c:3515:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT5659_PLL_M_SFT |
                                                            ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-12-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5651.c

index e59fdc8..49fab9d 100644 (file)
@@ -1498,8 +1498,8 @@ static int rt5651_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
        snd_soc_component_write(component, RT5651_PLL_CTRL1,
                pll_code.n_code << RT5651_PLL_N_SFT | pll_code.k_code);
        snd_soc_component_write(component, RT5651_PLL_CTRL2,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT5651_PLL_M_SFT |
-               pll_code.m_bp << RT5651_PLL_M_BP_SFT);
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5651_PLL_M_SFT) |
+               (pll_code.m_bp << RT5651_PLL_M_BP_SFT));
 
        rt5651->pll_in = freq_in;
        rt5651->pll_out = freq_out;