crash, powerpc: default to CRASH_DUMP=n on PPC_BOOK3S_32
authorDave Vasilevsky <dave@vasilevsky.ca>
Tue, 17 Sep 2024 16:37:20 +0000 (12:37 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 15 Nov 2024 06:43:48 +0000 (22:43 -0800)
Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using Open Firmware.
On these machines, the kernel refuses to boot from non-zero
PHYSICAL_START, which occurs when CRASH_DUMP is on.

Since most PPC_BOOK3S_32 machines boot via Open Firmware, it should
default to off for them.  Users booting via some other mechanism can still
turn it on explicitly.

Does not change the default on any other architectures for the
time being.

Link: https://lkml.kernel.org/r/20240917163720.1644584-1-dave@vasilevsky.ca
Fixes: 75bc255a7444 ("crash: clean up kdump related config items")
Signed-off-by: Dave Vasilevsky <dave@vasilevsky.ca>
Reported-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Closes: https://lists.debian.org/debian-powerpc/2024/07/msg00001.html
Acked-by: Michael Ellerman <mpe@ellerman.id.au> [powerpc]
Acked-by: Baoquan He <bhe@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/arm/Kconfig
arch/arm64/Kconfig
arch/loongarch/Kconfig
arch/mips/Kconfig
arch/powerpc/Kconfig
arch/riscv/Kconfig
arch/s390/Kconfig
arch/sh/Kconfig
arch/x86/Kconfig
kernel/Kconfig.kexec

index 749179a..202397b 100644 (file)
@@ -1598,6 +1598,9 @@ config ATAGS_PROC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config AUTO_ZRELADDR
        bool "Auto calculation of the decompressed kernel image address" if !ARCH_MULTIPLATFORM
        default !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
index fd9df6d..22ea270 100644 (file)
@@ -1576,6 +1576,9 @@ config ARCH_DEFAULT_KEXEC_IMAGE_VERIFY_SIG
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
        def_bool CRASH_RESERVE
 
index bb35c34..d9fce0f 100644 (file)
@@ -604,6 +604,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SELECTS_CRASH_DUMP
        def_bool y
        depends on CRASH_DUMP
index 397edf0..467b10f 100644 (file)
@@ -2876,6 +2876,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config PHYSICAL_START
        hex "Physical address where the kernel is loaded"
        default "0xffffffff84000000"
index 8094a01..1a2ff02 100644 (file)
@@ -684,6 +684,10 @@ config RELOCATABLE_TEST
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool PPC64 || PPC_BOOK3S_32 || PPC_85xx || (44x && !SMP)
 
+config ARCH_DEFAULT_CRASH_DUMP
+       bool
+       default y if !PPC_BOOK3S_32
+
 config ARCH_SELECTS_CRASH_DUMP
        def_bool y
        depends on CRASH_DUMP
index f4c5705..fa8f2da 100644 (file)
@@ -898,6 +898,9 @@ config ARCH_SUPPORTS_KEXEC_PURGATORY
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
        def_bool CRASH_RESERVE
 
index d339fe4..cc1f9cf 100644 (file)
@@ -276,6 +276,9 @@ config ARCH_SUPPORTS_CRASH_DUMP
          This option also enables s390 zfcpdump.
          See also <file:Documentation/arch/s390/zfcpdump.rst>
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 menu "Processor type and features"
 
 config HAVE_MARCH_Z10_FEATURES
index e910399..04ff5fb 100644 (file)
@@ -550,6 +550,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool BROKEN_ON_SMP
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SUPPORTS_KEXEC_JUMP
        def_bool y
 
index 16354df..7b9a7e8 100644 (file)
@@ -2084,6 +2084,9 @@ config ARCH_SUPPORTS_KEXEC_JUMP
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool X86_64 || (X86_32 && HIGHMEM)
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SUPPORTS_CRASH_HOTPLUG
        def_bool y
 
index 6c34e63..4d111f8 100644 (file)
@@ -97,7 +97,7 @@ config KEXEC_JUMP
 
 config CRASH_DUMP
        bool "kernel crash dumps"
-       default y
+       default ARCH_DEFAULT_CRASH_DUMP
        depends on ARCH_SUPPORTS_CRASH_DUMP
        depends on KEXEC_CORE
        select VMCORE_INFO