USB: cdc-acm: use common data-class define
authorJohan Hovold <johan@kernel.org>
Mon, 21 Sep 2020 13:59:50 +0000 (15:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Sep 2020 15:01:12 +0000 (17:01 +0200)
Use the data-class define provided by USB core and drop the
driver-specific one.

Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20200921135951.24045-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c
drivers/usb/class/cdc-acm.h

index 30137d1..cd738fb 100644 (file)
@@ -1288,10 +1288,8 @@ look_for_collapsed_interface:
 skip_normal_probe:
 
        /*workaround for switched interfaces */
-       if (data_interface->cur_altsetting->desc.bInterfaceClass
-                                               != CDC_DATA_INTERFACE_TYPE) {
-               if (control_interface->cur_altsetting->desc.bInterfaceClass
-                                               == CDC_DATA_INTERFACE_TYPE) {
+       if (data_interface->cur_altsetting->desc.bInterfaceClass != USB_CLASS_CDC_DATA) {
+               if (control_interface->cur_altsetting->desc.bInterfaceClass == USB_CLASS_CDC_DATA) {
                        dev_dbg(&intf->dev,
                                "Your device has switched interfaces.\n");
                        swap(control_interface, data_interface);
index a50ea39..96331c8 100644 (file)
@@ -131,8 +131,6 @@ struct acm {
        unsigned long quirks;
 };
 
-#define CDC_DATA_INTERFACE_TYPE        0x0a
-
 /* constants describing various quirks and errors */
 #define NO_UNION_NORMAL                        BIT(0)
 #define SINGLE_RX_URB                  BIT(1)