xhci: dbc: Use sizeof(*pointer) instead of sizeof(type)
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 1 Dec 2023 15:06:37 +0000 (17:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Dec 2023 06:50:40 +0000 (07:50 +0100)
It is preferred to use sizeof(*pointer) instead of sizeof(type).
The type of the variable can change and one needs not change
the former (unlike the latter). No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20231201150647.1307406-10-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-dbgcap.c

index 0c9fd61..73494d5 100644 (file)
@@ -380,7 +380,7 @@ static void xhci_dbc_eps_exit(struct xhci_dbc *dbc)
 static int dbc_erst_alloc(struct device *dev, struct xhci_ring *evt_ring,
                    struct xhci_erst *erst, gfp_t flags)
 {
-       erst->entries = dma_alloc_coherent(dev, sizeof(struct xhci_erst_entry),
+       erst->entries = dma_alloc_coherent(dev, sizeof(*erst->entries),
                                           &erst->erst_dma_addr, flags);
        if (!erst->entries)
                return -ENOMEM;
@@ -394,7 +394,7 @@ static int dbc_erst_alloc(struct device *dev, struct xhci_ring *evt_ring,
 
 static void dbc_erst_free(struct device *dev, struct xhci_erst *erst)
 {
-       dma_free_coherent(dev, sizeof(struct xhci_erst_entry), erst->entries,
+       dma_free_coherent(dev, sizeof(*erst->entries), erst->entries,
                          erst->erst_dma_addr);
        erst->entries = NULL;
 }
@@ -494,7 +494,7 @@ static int xhci_dbc_mem_init(struct xhci_dbc *dbc, gfp_t flags)
                goto ctx_fail;
 
        /* Allocate the string table: */
-       dbc->string_size = sizeof(struct dbc_str_descs);
+       dbc->string_size = sizeof(*dbc->string);
        dbc->string = dma_alloc_coherent(dev, dbc->string_size,
                                         &dbc->string_dma, flags);
        if (!dbc->string)