projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5866065
)
Input: atkbd - use guard notation when pausing serio port
author
Dmitry Torokhov
<dmitry.torokhov@gmail.com>
Thu, 5 Sep 2024 04:17:11 +0000
(21:17 -0700)
committer
Dmitry Torokhov
<dmitry.torokhov@gmail.com>
Fri, 4 Oct 2024 07:58:15 +0000
(
00:58
-0700)
Using guard notation makes the code more compact and error handling
more robust by ensuring that serio ports are resumed in all code paths
when control leaves critical section.
Link:
https://lore.kernel.org/r/20240905041732.2034348-7-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/atkbd.c
patch
|
blob
|
history
diff --git
a/drivers/input/keyboard/atkbd.c
b/drivers/input/keyboard/atkbd.c
index
5855d4f
..
ec94fcf
100644
(file)
--- a/
drivers/input/keyboard/atkbd.c
+++ b/
drivers/input/keyboard/atkbd.c
@@
-713,9
+713,9
@@
static int atkbd_event(struct input_dev *dev,
static inline void atkbd_enable(struct atkbd *atkbd)
{
- serio_pause_rx(atkbd->ps2dev.serio);
+ guard(serio_pause_rx)(atkbd->ps2dev.serio);
+
atkbd->enabled = true;
- serio_continue_rx(atkbd->ps2dev.serio);
}
/*
@@
-725,9
+725,9
@@
static inline void atkbd_enable(struct atkbd *atkbd)
static inline void atkbd_disable(struct atkbd *atkbd)
{
- serio_pause_rx(atkbd->ps2dev.serio);
+ guard(serio_pause_rx)(atkbd->ps2dev.serio);
+
atkbd->enabled = false;
- serio_continue_rx(atkbd->ps2dev.serio);
}
static int atkbd_activate(struct atkbd *atkbd)