usb: xhci: Cleanup printk debug message for ERST
authorLu Baolu <baolu.lu@linux.intel.com>
Fri, 8 Dec 2017 15:59:12 +0000 (17:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Dec 2017 16:43:52 +0000 (17:43 +0100)
Each event segment has been exposed through debugfs. There is no
need to dump ERST content with printk in code. Remove it to make
code more concise and readable.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-dbg.c
drivers/usb/host/xhci.c
drivers/usb/host/xhci.h

index f20ef2e..386abf2 100644 (file)
 
 #include "xhci.h"
 
-void xhci_dbg_erst(struct xhci_hcd *xhci, struct xhci_erst *erst)
-{
-       u64 addr = erst->erst_dma_addr;
-       int i;
-       struct xhci_erst_entry *entry;
-
-       for (i = 0; i < erst->num_entries; i++) {
-               entry = &erst->entries[i];
-               xhci_dbg(xhci, "@%016llx %08x %08x %08x %08x\n",
-                        addr,
-                        lower_32_bits(le64_to_cpu(entry->seg_addr)),
-                        upper_32_bits(le64_to_cpu(entry->seg_addr)),
-                        le32_to_cpu(entry->seg_size),
-                        le32_to_cpu(entry->rsvd));
-               addr += sizeof(*entry);
-       }
-}
-
 char *xhci_get_slot_state(struct xhci_hcd *xhci,
                struct xhci_container_ctx *ctx)
 {
index a66540d..060e5b4 100644 (file)
@@ -574,8 +574,6 @@ int xhci_run(struct usb_hcd *hcd)
        if (ret)
                return ret;
 
-       xhci_dbg(xhci, "ERST memory map follows:\n");
-       xhci_dbg_erst(xhci, &xhci->erst);
        temp_64 = xhci_read_64(xhci, &xhci->ir_set->erst_dequeue);
        temp_64 &= ~ERST_PTR_MASK;
        xhci_dbg_trace(xhci, trace_xhci_dbg_init,
index 8ab2d83..7c87817 100644 (file)
@@ -1925,7 +1925,6 @@ static inline int xhci_link_trb_quirk(struct xhci_hcd *xhci)
 }
 
 /* xHCI debugging */
-void xhci_dbg_erst(struct xhci_hcd *xhci, struct xhci_erst *erst);
 char *xhci_get_slot_state(struct xhci_hcd *xhci,
                struct xhci_container_ctx *ctx);
 void xhci_dbg_trace(struct xhci_hcd *xhci, void (*trace)(struct va_format *),