ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 22 Jan 2021 11:02:34 +0000 (12:02 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 12 Feb 2021 04:12:59 +0000 (23:12 -0500)
EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
user may not want to enable.  Fix this by making the test depend on
EXT4_FS instead.

Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20210122110234.2825685-1-geert@linux-m68k.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/Kconfig

index 619dd35..86699c8 100644 (file)
@@ -103,8 +103,7 @@ config EXT4_DEBUG
 
 config EXT4_KUNIT_TESTS
        tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
-       select EXT4_FS
-       depends on KUNIT
+       depends on EXT4_FS && KUNIT
        default KUNIT_ALL_TESTS
        help
          This builds the ext4 KUnit tests.