ASoC: sunxi: sun4i-codec: silence misleading error in probe
authorMikhail Rudenko <mike.rudenko@gmail.com>
Sun, 11 Sep 2022 14:57:11 +0000 (17:57 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 13 Sep 2022 16:12:07 +0000 (17:12 +0100)
In the case when a codec device is probed before codec analog
controls, snd_soc_register_card() returns -EPROBE_DEFER, resulting in
a misleading error message

    sun4i-codec 1c22c00.codec: Failed to register our card

even if the device is probed successfully later. Use dev_err_probe()
to demote the above error to a debug message.

Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220911145713.55199-1-mike.rudenko@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-codec.c

index 830beb3..3a7075d 100644 (file)
@@ -1804,7 +1804,7 @@ static int sun4i_codec_probe(struct platform_device *pdev)
 
        ret = snd_soc_register_card(card);
        if (ret) {
-               dev_err(&pdev->dev, "Failed to register our card\n");
+               dev_err_probe(&pdev->dev, ret, "Failed to register our card\n");
                goto err_assert_reset;
        }