crypto: keembay-ocs-aes - Fix error return code in kmb_ocs_aes_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 10 Feb 2021 07:45:27 +0000 (07:45 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 7 Mar 2021 04:13:15 +0000 (15:13 +1100)
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/keembay/keembay-ocs-aes-core.c

index b6b25d9..2ef3128 100644 (file)
@@ -1649,8 +1649,10 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev)
 
        /* Initialize crypto engine */
        aes_dev->engine = crypto_engine_alloc_init(dev, true);
-       if (!aes_dev->engine)
+       if (!aes_dev->engine) {
+               rc = -ENOMEM;
                goto list_del;
+       }
 
        rc = crypto_engine_start(aes_dev->engine);
        if (rc) {