usb: phy: phy-mxs-usb: Use of_device_get_match_data()
authorFabio Estevam <festevam@gmail.com>
Mon, 18 Jan 2021 15:26:15 +0000 (12:26 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Jan 2021 17:35:46 +0000 (18:35 +0100)
The retrieval of driver data via of_device_get_match_data() can make
the code simpler.

Use of_device_get_match_data() to simplify the code.

Acked-by: Peter Chen <peter.chen@nxp.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20210118152615.1644861-1-festevam@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/phy/phy-mxs-usb.c

index 67b39dc..8a262c5 100644 (file)
@@ -714,14 +714,9 @@ static int mxs_phy_probe(struct platform_device *pdev)
        struct clk *clk;
        struct mxs_phy *mxs_phy;
        int ret;
-       const struct of_device_id *of_id;
        struct device_node *np = pdev->dev.of_node;
        u32 val;
 
-       of_id = of_match_device(mxs_phy_dt_ids, &pdev->dev);
-       if (!of_id)
-               return -ENODEV;
-
        base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);
@@ -797,7 +792,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
        mxs_phy->phy.charger_detect     = mxs_phy_charger_detect;
 
        mxs_phy->clk = clk;
-       mxs_phy->data = of_id->data;
+       mxs_phy->data = of_device_get_match_data(&pdev->dev);
 
        platform_set_drvdata(pdev, mxs_phy);