cpuidle: tegra: Remove do_idle firmware call
authorDmitry Osipenko <digetx@gmail.com>
Tue, 2 Mar 2021 09:54:05 +0000 (12:54 +0300)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 8 Apr 2021 17:54:14 +0000 (19:54 +0200)
The do_idle firmware call is unused by all Tegra SoCs, hence remove it in
order to keep driver's code clean.

Tested-by: Anton Bambura <jenneron@protonmail.com> # TF701 T114
Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210302095405.28453-2-digetx@gmail.com
drivers/cpuidle/cpuidle-tegra.c

index 29c5e83..508bd9f 100644 (file)
@@ -48,11 +48,6 @@ enum tegra_state {
 static atomic_t tegra_idle_barrier;
 static atomic_t tegra_abort_flag;
 
-static inline bool tegra_cpuidle_using_firmware(void)
-{
-       return firmware_ops->prepare_idle && firmware_ops->do_idle;
-}
-
 static void tegra_cpuidle_report_cpus_state(void)
 {
        unsigned long cpu, lcpu, csr;
@@ -139,10 +134,6 @@ static int tegra_cpuidle_c7_enter(void)
        if (err && err != -ENOSYS)
                return err;
 
-       err = call_firmware_op(do_idle, 0);
-       if (err != -ENOSYS)
-               return err;
-
        return cpu_suspend(0, tegra30_pm_secondary_cpu_suspend);
 }
 
@@ -356,9 +347,7 @@ static int tegra_cpuidle_probe(struct platform_device *pdev)
         * is disabled.
         */
        if (!IS_ENABLED(CONFIG_PM_SLEEP)) {
-               if (!tegra_cpuidle_using_firmware())
-                       tegra_cpuidle_disable_state(TEGRA_C7);
-
+               tegra_cpuidle_disable_state(TEGRA_C7);
                tegra_cpuidle_disable_state(TEGRA_CC6);
        }