pata_rb532_cf: fix deferred probing
authorSergey Shtylyov <s.shtylyov@omprussia.ru>
Mon, 15 Mar 2021 11:46:53 +0000 (14:46 +0300)
committerJens Axboe <axboe@kernel.dk>
Tue, 18 May 2021 21:17:56 +0000 (15:17 -0600)
The driver overrides the error codes returned by platform_get_irq() to
-ENOENT, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream, still checking/overriding IRQ0 as libata regards it
as "no IRQ" (thus polling) anyway...

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Link: https://lore.kernel.org/r/771ced55-3efb-21f5-f21c-b99920aae611@omprussia.ru
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/ata/pata_rb532_cf.c

index 479c4b2..303f8c3 100644 (file)
@@ -115,10 +115,12 @@ static int rb532_pata_driver_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
+       if (irq < 0) {
                dev_err(&pdev->dev, "no IRQ resource found\n");
-               return -ENOENT;
+               return irq;
        }
+       if (!irq)
+               return -EINVAL;
 
        gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_IN);
        if (IS_ERR(gpiod)) {