neighbour: Use nlmsg_payload in neigh_valid_get_req

Update neigh_valid_get_req function to utilize the new nlmsg_payload()
helper function.

This change improves code clarity and safety by ensuring that the
Netlink message payload is properly validated before accessing its data.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250414-nlmsg-v2-3-3d90cb42c6af@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index b6bc483..65cf582 100644 (file)
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2855,12 +2855,12 @@ static int neigh_valid_get_req(const struct nlmsghdr *nlh,
        struct ndmsg *ndm;
        int err, i;
 
-       if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ndm))) {
+       ndm = nlmsg_payload(nlh, sizeof(*ndm));
+       if (!ndm) {
                NL_SET_ERR_MSG(extack, "Invalid header for neighbor get request");
                return -EINVAL;
        }
 
-       ndm = nlmsg_data(nlh);
        if (ndm->ndm_pad1  || ndm->ndm_pad2  || ndm->ndm_state ||
            ndm->ndm_type) {
                NL_SET_ERR_MSG(extack, "Invalid values in header for neighbor get request");