drm/vmwgfx: Fix incorrect enum usage
authorZack Rusin <zackr@vmware.com>
Wed, 5 May 2021 03:57:35 +0000 (23:57 -0400)
committerZack Rusin <zackr@vmware.com>
Tue, 11 May 2021 17:06:56 +0000 (13:06 -0400)
SVGA_REG_ENABLE is a register name, and SVGA_REG_ENABLE_(ENABLE|
DISABLE|HIDE) are its valid values. We were incorrectly setting
the register value to itself. This happened to work because
the SVGA_REG_ENABLE is happens to to be the same value as
SVGA_REG_ENABLE_ENABLE, but is still semantically incorrect.
Lets use the correct enum when setting SVGA_REG_ENABLE.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210505035740.286923-2-zackr@vmware.com
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

index 7805ba0..1b27d7f 100644 (file)
@@ -1179,7 +1179,7 @@ static void __vmw_svga_enable(struct vmw_private *dev_priv)
        struct ttm_resource_manager *man = ttm_manager_type(&dev_priv->bdev, TTM_PL_VRAM);
 
        if (!ttm_resource_manager_used(man)) {
-               vmw_write(dev_priv, SVGA_REG_ENABLE, SVGA_REG_ENABLE);
+               vmw_write(dev_priv, SVGA_REG_ENABLE, SVGA_REG_ENABLE_ENABLE);
                ttm_resource_manager_set_used(man, true);
        }
 }